Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): fixed example mail display time bug #3595

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

FlemingVincent
Copy link

@FlemingVincent FlemingVincent commented Apr 24, 2024

Bug

The <MailDisplay /> component was formatting times incorrectly. This was caused by an incorrect option when using the format() function from date-fns.

screencapture-ui-shadcn-examples-mail-2024-04-24-19_05_13

Fix

Instead of using the option ""E, h:m b"", I replaced it with ""E, h:mm b"", which always displays two digits.

screencapture-localhost-3003-2024-04-24-19_09_58

Testing

All tests are passing.

Screenshot 2024-04-24 at 7 22 33 PM

Copy link

vercel bot commented Apr 24, 2024

@FlemingVincent is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@ruru-m07 ruru-m07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thalesfsp
Copy link

Who needs to authorize this? 2w already open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants