Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge existing tailwind config #3558

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

juliusmarminge
Copy link

@juliusmarminge juliusmarminge commented Apr 20, 2024

this merges the existing tailwind config to not remove any existing config when initializing the shadcn-ui config.

before (custom font settings was removed):

image

after (font config is preserved):

CleanShot 2024-04-20 at 23 18 05@2x

note that it's json-quoted but i don't think this is an issue as the previous solution also didn't produce an output that adhered to the user's formatting rules (use of single-quotes, semis etc etc). could ship prettier and run that on the file before writing, but with other formatters like biome getting popular i don't think this is worth it, and a manual save by the user is adequate)

Copy link

vercel bot commented Apr 20, 2024

@juliusmarminge is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@Nsttt
Copy link

Nsttt commented Apr 20, 2024

That's looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants