feat: ✨ new spinner component #3554
Open
+569
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@flixlix is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
|
close #2766 |
ruru-m07
approved these changes
Apr 21, 2024
cmawhorter
reviewed
Apr 26, 2024
| {...props} | ||
| > | ||
| <div className="relative left-1/2 top-1/2 size-full"> | ||
| {[...Array(12)].map((_, i) => ( |
There was a problem hiding this comment.
creating 12 divs inline seems like a funky way of achieving this, no?
There was a problem hiding this comment.
Yeah i'll admit it, that this doesn't seem like good practice, but to be fair this is how I saw most spinners from other design systems being implemented
There was a problem hiding this comment.
@cmawhorter any suggestions on how you would implement this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-04-20.at.15.17.22.mov