fix(mdx): rehype pretty code title not showing in light mode #3519
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RahimGuerfi is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
ruru-m07
approved these changes
Apr 18, 2024
|
oh man, just saw this now after creating my PR #3552, but I still think my implementation is cleaner, with just |
it's okay and yeah your implementation is better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses visibility issues in light mode where the code block title was blending with the white background due to the "text-white" Tailwind class. To improve readability, I changed the title color to black for light themes and white for dark themes, ensuring better contrast and legibility across different modes.
Before applying the fix:
After applying the fix:
