Replace webpack and CRA with vite #281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move index.html to root directory. 🙄 Import the CJS modules using `import *` syntax to get the compile errors to stop, though it probably won't work. Add vite, react plugin and vite.config.js.
Without it, we can't access the vite dev server from outside docker. Use * instead of the file: path for the shared package, so that changes are picked up immediately. Use the correct comboBox import instead of using a relative path to node_modules. Change convertToPropType.js to ESM. Add shared to the workspaces array. Tell prettier to ignore vite.config.js.
Clarify how sub-package imports work with shared.
Move the test command into e2e/package.json from the playwright config. Clean up client/package.json. Seriously, go away prettier.
fwextensions
force-pushed
the
jdunning/feat/try-vite
branch
from
0c50c5b to
d39320e
Compare
Move dev deps to devDeps in client/package.json. Remove setupProxy.js, which is no longer needed.
Avoids having to use ../shared in optimizeDeps inside vite.config.js.
Update shared/README.md with info on the difference.
fwextensions
force-pushed
the
jdunning/feat/try-vite
branch
from
3eba4f4 to
1a38234
Compare
That command never finishes, so having it in the e2e test script means playwright never gets started.
fwextensions
changed the title
|
@francisli this branch seems to be fully working now, if you want to take a look. Do you know where the path to /client/build is specified for the server? The default build folder for Vite is dist, and the server wasn't finding that during CI/CD. |
|
Closing in favor of #315 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrestled vite into submission.