Test Storybook support #277
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use webpack5 builder. Add main.js and preview.js.
Storybook is complaining about conflicts in the configs, so remove them for now. Go back to using the react preset for now, instead of craco.
Move storybook eslint config to top-level package.json. Update core.builder config in main.js. Add TabBar.stories.jsx. Add a story() helper in RingdownBadge.stories.jsx.
Fix header click handling in TabBar.stories.jsx. Fix default routes and names of stories. Move static dir config to main.js instead of a flag in the npm scripts, and add /build. Add link to USWDS CSS in preview-head.html so the components look right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found my old Storybook branch, rebased it on main and got it working. (The issue had been the same annoying eslint config problems, which have since been fixed.)
This PR contains a few stories as examples of showing the Routed components.