-
Notifications
You must be signed in to change notification settings - Fork 13
Maintain collapsed state of Ringdowns list when switching tabs in ER view #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kretzbryan
wants to merge
10
commits into
main
Choose a base branch
from
bkretz/bug/240
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1704754
add useEffect to RingdownSection.js
kretzbryan f380549
Merge branch 'main' into bkretz/bug/240
kretzbryan 3e74953
expanded value for RingdownSection.js set to localstorage
kretzbryan acd26b1
Merge branch 'main' into bkretz/bug/240
kretzbryan 08eaefe
moved ringdown section ui logic to Context
kretzbryan 9e695a0
move UIContext to own file, HOC created for UIContextProvider
kretzbryan 09f4834
Merge branch 'main' into bkretz/bug/240
kretzbryan 49c1bd0
unused state removed from Context.js, setting initial state in UICont…
kretzbryan cdbbe19
rename UIContext/provider to ERContext/Provider, move ERContext to ER…
kretzbryan ae86ab6
Merge branch 'main' into bkretz/bug/240
kretzbryan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
import React from 'react'; | ||
import { UIContextProvider } from '../UIContext'; | ||
|
||
const withUIContext = (WrappedComponent) => { | ||
kretzbryan marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
const WithUIContext = ({ ...props }) => { | ||
return ( | ||
<UIContextProvider> | ||
<WrappedComponent {...props} />; | ||
</UIContextProvider> | ||
); | ||
}; | ||
|
||
return WithUIContext; | ||
}; | ||
|
||
export default withUIContext; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
import React, { createContext, useState } from 'react'; | ||
kretzbryan marked this conversation as resolved.
Show resolved
Hide resolved
|
||
import PropTypes from 'prop-types'; | ||
|
||
const UIContext = createContext(); | ||
|
||
function UIContextProvider({ children }) { | ||
const [ringdownSections, setRingdownSections] = useState(); | ||
|
||
const value = { | ||
ringdownSections, | ||
setRingdownSections, | ||
}; | ||
return <UIContext.Provider value={value}>{children}</UIContext.Provider>; | ||
} | ||
UIContextProvider.propTypes = { | ||
children: PropTypes.oneOfType([PropTypes.arrayOf(PropTypes.node), PropTypes.node]).isRequired, | ||
}; | ||
|
||
export { UIContextProvider }; | ||
|
||
export default UIContext; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.