Updated Conversation Settings - 1 #459
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 20 commits
May 14, 2025 11:43
…tor on options in confirmation modal
RyanRory
changed the title
mpretty-cyro
requested changes
Jun 2, 2025
There was a problem hiding this comment.
- Looks like there is an issue with the multi-user group avatar for the settings button in the conversation (see this conversation in the convo list and in the convo screen)
- If you rapidly tap the "View More"/"View Less" button over and over it eventually seems to get stuck with one of the two heights (need to leave the screen and return to fix it)
- When you delete a contact it remains on an empty settings screen briefly before returning to the conversation list (ideally it would pop immediately and trigger the deletion async in the background so there isn't any empty screen shown)
Screen.Recording.2025-06-02.at.10.00.54.am.mov
- Not sure if the requirements changed but should local errors be appearing immediately instead of waiting for submission? (when I enter a group name that is too long the error doesn't appear until
Saveis presssed)
added 7 commits
June 3, 2025 11:34
mpretty-cyro
reviewed
Jun 5, 2025
| db, | ||
| threadId: threadViewModel.id, | ||
| threadVariant: threadViewModel.threadVariant, | ||
| options: [.local, .noArtifacts], |
mpretty-cyro
requested changes
Jun 5, 2025
mpretty-cyro
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ThreadSettingsViewModelThreadNotificationSettingsViewModel