DBR - 6 - Remove database from message sending pipeline, send busy call message #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpretty-cyro
added
enhancement
• Updated the General cache to include the users seckey (rather than fetching it from the DB every time causing unneeded load) • Updated a bunch of Crypto usage to no longer need a `db` or `dependencies` instance passed to it • Added unit tests for General.Cache • Replaced `Identity.userExists` with `General.Cache.userExists` (no need for database access anymore) • Moved the SwarmPoller message handling logic into it's own function to make debugging stack traces a little easier • Cleaned up some hard-to-read logic
• Added the new MessageDeduplication table • Added a migration to populate the MessageDeduplication table • Added ExtensionHelper functions to store records in the AppGroup for deduplication purposes • Updated the logic to use MessageDeduplication table & files for deduplication purposes • Refactored message parsing to not rely on the database • Refactored message deduplication to not rely on the database in the PN extension • Removed the old ControlMessageProcessRecord table
• Refactored the MessageSender to no longer require database access • Refactored the attachment upload process to no longer require database access • Updated the OpenGroupAPI to no longer require database access • Added back logic to send the `endCall` message when receiving a call while on another call • Added `community` to `AuthenticationMethod` to help standardise the code behaviour • Updated the `toProto` functions to no longer required a `Database` instance • Updated a bunch of functions to be @mainactor (so we can ditch thread swapping code)
• Updated SessionNetworkAPI so preparing requests doesn't use the database • Fixed build errors
mpretty-cyro
force-pushed
the
feature/dbr6-handle-call-busy
branch
from
e9deaf7 to
b4cde8e
Compare
RyanRory
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toProtofunctions to no longer required aDatabaseinstanceendCallmessage when receiving a call while on another callcommunitytoAuthenticationMethodto help standardise the code behaviourThis PR is based on #451