Fix stylo compilation on wasm32-unknown-unknown target
#78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Submitted upstream as https://bugzilla.mozilla.org/show_bug.cgi?id=1933015 |
|
Looks like this needs a bit of refinement since it was reverted upstream. |
|
Yeah, this is causing some kind of issue with Gecko's C bindings to Stylo. Will need to investigate. |
nicoburns
force-pushed
the
fix-wasm
branch
2 times, most recently
from
519108f to
e531906
Compare
Any ancestors of this commit are from upstream mozilla-central, with some filtering and renaming. Our patches and sync tooling start here. The sync tooling has all been squashed into this commit, based on: https://github.com/servo/stylo/commits/64731e10dc8ef87ef52aa2fb9f988c3b2530f3a7
This is a rebase of 42990da Signed-off-by: Oriol Brufau <[email protected]>
Signed-off-by: Oriol Brufau <[email protected]>
Signed-off-by: Oriol Brufau <[email protected]>
Signed-off-by: Oriol Brufau <[email protected]>
…d` (servo#128) Signed-off-by: Euclid Ye <[email protected]>
* Remove unecessary import Signed-off-by: Nico Burns <[email protected]> * Uneeded Debug import Signed-off-by: Nico Burns <[email protected]> * Remove duplicate cfg attr Signed-off-by: Nico Burns <[email protected]> --------- Signed-off-by: Nico Burns <[email protected]>
Signed-off-by: Nico Burns <[email protected]>
Signed-off-by: Jason Tsai <[email protected]>
…its (servo#102) Signed-off-by: Asun0204 <[email protected]>
…static_prefs` crates (servo#131) * Update metadata AND update dep version for stylo_dom crate * Update metadata AND update dep version for stylo_static_prefs * Update metadata AND update dep version for stylo_config * Add metadata to servo_atoms crate Signed-off-by: Nico Burns <[email protected]> * Rename servo_atoms to stylo_atoms Signed-off-by: Nico Burns <[email protected]> * Update descriptions Signed-off-by: Nico Burns <[email protected]> * Make directory names match crate names Signed-off-by: Nico Burns <[email protected]> --------- Signed-off-by: Nico Burns <[email protected]>
Signed-off-by: Nico Burns <[email protected]>
* Replace lazy_static with LazyLock in style_config crate Signed-off-by: Nico Burns <[email protected]> * Remove needed closure Co-authored-by: Oriol Brufau <[email protected]> Signed-off-by: Nico Burns <[email protected]> --------- Signed-off-by: Nico Burns <[email protected]> Co-authored-by: Oriol Brufau <[email protected]>
Signed-off-by: Nico Burns <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1933015