Implement attributes for the <meter> element
#32230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanehandley
force-pushed
the
meter-element-attributes
branch
2 times, most recently
from
550a5ec
to
740bca5
Compare
mukilan
added
T-linux-wpt-2013
github-actions
bot
removed
T-linux-wpt-2013
|
🔨 Triggering try run (#8967676784) for Linux WPT |
|
Test results for linux-wpt-layout-2020 from try job (#8967676784): Flaky unexpected result (23)
Stable unexpected results that are known to be intermittent (18)
Stable unexpected results (3)
|
|
Test results for linux-wpt-layout-2013 from try job (#8967676784): Flaky unexpected result (12)
Stable unexpected results that are known to be intermittent (14)
Stable unexpected results (3)
|
|
|
shanehandley
force-pushed
the
meter-element-attributes
branch
from
740bca5
to
c0e8bee
Compare
sagudev
reviewed
May 6, 2024
Comment on lines
3383
to
3384
| [meter.value: IDL set to -0] | ||
| expected: FAIL |
There was a problem hiding this comment.
Apparently some setters do not work correctly (maybe wrong parsing?).
There was a problem hiding this comment.
Sorry for not responding to this comment yet but I went down a rabbit hole, I switched the setter implementations to parse_floating_point_number before setting the value, but the issue persisted.
I'm really unsure if this is something in parse_floating_point_number or not :/
Spidermonkey's parseFloat(-0.0) returns 0. But our implementation returns -0.0 - do you think this might be a factor or am I barking up the wrong tree?
Thank you!
There was a problem hiding this comment.
I think that our parse_floating_point_number is wrong, but we can leave this for follow up. In firefox the corresponding function is actually https://searchfox.org/mozilla-central/source/dom/base/nsAttrValue.cpp#1892 (you can see it's only used on progress and meter element just like ours).
|
For reference, impl in firefox: https://searchfox.org/mozilla-central/source/dom/html/HTMLMeterElement.cpp |
shanehandley
force-pushed
the
meter-element-attributes
branch
from
c0e8bee
to
48aa090
Compare
sagudev
added
T-linux-wpt-2013
github-actions
bot
removed
T-linux-wpt-2013
|
🔨 Triggering try run (#9030565993) for Linux WPT |
|
Test results for linux-wpt-layout-2013 from try job (#9030565993): Flaky unexpected result (15)
Stable unexpected results that are known to be intermittent (10)
|
|
Test results for linux-wpt-layout-2020 from try job (#9030565993): Flaky unexpected result (13)
Stable unexpected results that are known to be intermittent (9)
|
|
✨ Try run (#9030565993) succeeded. |
sagudev
approved these changes
May 11, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement attributes for the html
<meter>element.https://html.spec.whatwg.org/multipage/form-elements.html#the-meter-element
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors