feat: Implement Duplex destroy #2831
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@reconbot Could you please take a look at this? |
|
@reconbot, could you please let me know if this PR is in the right direction? Or if there's some other intended way to clean up a SerialPort object? |
|
+1 - would also like to see this fix (or similar) merged, as the current behavior in #2776 is quite tricky to work around. |
|
for your consideration, @reconbot |
|
@HipsterBrown maybe you can help? |
|
Rebased |
|
@reconbot I think this PR is production-ready. If not, could you please let me know what I need to do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there was no way to close a port reliably with this API. If you open a port, trying to
.closebefore it's done opening would throw an error and leave the underlying port open. If you used node's.destroy(),stream.addAbortSignal(), or[Symbol.asyncDispose], the underlying port would remain in an open state.This change implements the
Duplex.destroymethod. This is different from.closein that once aSerialPortStreamis destroyed, it cannot be opened again.