Pass scalar by values for user functions #2098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing scalar by ref (through universal reference) leads to worst code, so avoid the situation when we can.
serge-sans-paille
force-pushed
the
feature/by-value
branch
from
ea1bf33 to
984ae88
Compare
|
@jeanlaroche following up on your comments in #2095 on that PR : yeah I do plan to merge this one, but it's the most ground-breaking one, so let's dive into your issues, would you be able to share the whole error log and/or a minimal reproducer? |
|
I'm confused. I haven't tried 2095, even though I commented in there...
Should I?
And yes, I'll pasted my errors.
…On 4/14/23 2:47 PM, serge-sans-paille wrote:
@jeanlaroche <https://github.com/jeanlaroche> following up on your
comments in #2095
<#2095> on that PR
: yeah I do plan to merge this one, but it's the most ground-breaking
one, so let's dive into your issues, would you be able to share the
whole error log and/or a minimal reproducer?
—
Reply to this email directly, view it on GitHub
<#2098 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGUBEPMN6VTVWDZ5C6STHQ3XBHAXBANCNFSM6AAAAAAW5RD47I>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Here's the full error:
https://pastebin.com/PgjxVGrs
It's likely connected to code that I have to call a tensorflow library
from the C++ code generated by pythran, but just in case that's not it.
Jean
…On 4/14/23 2:47 PM, serge-sans-paille wrote:
@jeanlaroche <https://github.com/jeanlaroche> following up on your
comments in #2095
<#2095> on that PR
: yeah I do plan to merge this one, but it's the most ground-breaking
one, so let's dive into your issues, would you be able to share the
whole error log and/or a minimal reproducer?
—
Reply to this email directly, view it on GitHub
<#2098 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGUBEPMN6VTVWDZ5C6STHQ3XBHAXBANCNFSM6AAAAAAW5RD47I>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@jeanlaroche could you share the original python code? |
|
OK I took a closer look at the code. The issue is that the calling convention used by pythran has changed with this PR so I needed to update some patches accordingly. Once I do that the compilation error disappears. |
|
@jeanlaroche can I take this as a green light to merge this PR? |
|
yes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
passing scalar by ref (through universal reference) leads to worst code, so avoid the situation when we can.