-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#44 separate header from text paragraph #47
Open
TobiasZawada
wants to merge
91
commits into
sensorflo:master
Choose a base branch
from
bbatsov:work/44SeparateHeaderFromTextParagraph
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
#44 separate header from text paragraph #47
TobiasZawada
wants to merge
91
commits into
sensorflo:master
from
bbatsov:work/44SeparateHeaderFromTextParagraph
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use mode-* to set var require-final-newline
* edit to remove some of the warnings from flycheck * Re-formulate first comment line of adoctest-trans. Additionally delete some trailing spaces. Co-authored-by: phelanm <[email protected]> Co-authored-by: Tobias Zawada <[email protected]>
…aragraph-sequence
I've also added a bunch of hacking guidelines for potential contributors.
Basically the whole README was repeated there, which is quite wasteful. I've also killed all the trailing whitespace.
+ some indentation fixes.
- Set text property `font-lock-fontified` for fontified code blocks - also fix compiler error by quoting lambdas with sharp quote Co-authored-by: Tobias Zawada <[email protected]>
Replace `re-search-forward` by `adoc-kwf-search` in font-lock keywords. `adoc-kwf-search` continues search if the adoc-code-block text property is set at the matching position.
Also add ert test for keyword-replacement
…mment with adoc manual reference.
Also ignore whitespace at the end of the block attribute line.
Add ert tests for - literal code blocks (....) - ignored whitespace after leading comma of 2nd attribute and at end of attr line
760a76d
to
497bb8b
Compare
tarsius
pushed a commit
to emacsmirror/adoc-mode
that referenced
this pull request
Feb 12, 2024
* sensorflo#47 Adapt display-images from markdown-mode to adoc-mode * Toggle display of images * Try to get working CI-tests by requiring mouse and image * Correct package version from markdown 0.8.0 to adoc 0.9.0. * Remove dependency on context-menu-mode. * Avoid failing CI-tests through attempt to show images at start * when-let has moved from subr-x to subr * Tell the byte-compiler that imagep and image-flush are defined. * In defcustom booleanp is not a valid type. * Add display of images to README.adoc. - remove more "markdown" and "inline" - add context menu to image links - fontification of images before fontification of general links, since image links can contain urls * require subr-x simplification * Rename adoc-display-images-at-startup to adoc-display-images. Add Usage section to README.adoc with a description of the not so obvious features. --------- Co-authored-by: Tobias Zawada <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move one-line-header regexp from
adoc-re-paragraph-start
toadoc-re-paragraph-separate
.paragraph-separate
is merged intoparagraph-start
anyway.This should fix issue #44.