Wrong georeferencing of angles grid in S2Resampler.java? #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Please, could someone have a look to that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@marpet Is it possible that there is a mistake in the georeferencing of the grid of angles when converting to image in updateAngleBands ?
Considering the detector footprint gml vector as the truth, the current georeferencing does not seem to align/cover well with the detector footprint. Indeed, it seems to align/center better shifting the upper-left corner by half a pixel.
Below is the detector footprints as a vector (gml) over one of the detector rasters (detectorId=6 in that case). It was taken from band "B02" of scene "S2B_MSIL1C_20181225T092409_N0207_R093_T33NTD_20181225T113038.SAFE"
If it is the case, the current PR shifts the origin of the angle image of half a pixel compared to the origin of the angle grid, so that the pixel center coordinates align well with the grid.
I am sorry I did not use the forum for that, but I was not allowed to post as my forum account was new, and I did not find any specification on how to get that permission...