Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies versions #109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .eslintignore

This file was deleted.

11 changes: 5 additions & 6 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v4
with:
node-version: 21.7
node-version: 23.4

- name: npm install
run: npm install
Expand All @@ -34,7 +34,7 @@ jobs:

[ $code -eq 1 ] && echo 'Error: Check should succeed' && exit 1

grep 'success: true' check_report
grep '"success":true' check_report

- name: test check should fail
run: |
Expand All @@ -47,7 +47,7 @@ jobs:

[ $code -eq 0 ] && echo 'Error: Check should fail' && exit 1

grep 'success: false' check_report
grep '"success":false' check_report
grep "Element 'body' does not contain 'No Way'" check_report

- name: test check lighthouse
Expand All @@ -63,9 +63,8 @@ jobs:
set -e
cat check_report
[ $code -eq 1 ] && echo 'Error: Check should succeed' && exit 1
grep 'success: true' check_report
grep "labels: { name: 'first-contentful-paint', id: 'lh-one' }" \
check_report
grep '"success":true' check_report
grep '{"labels":{"id":"lh-one","name":"first-contentful-paint"}' check_report

- name: 'lint configs'
run: npm run prettier
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
override APPLICATION_NAME=purr
override NODE_VERSION=21.7
override NODE_VERSION=23.4

DOCKER_IMAGE?=ghcr.io/semrush/purr
DOCKER_TAG?=latest
Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG NODE_VERSION=21.7
ARG NODE_VERSION=23.4

FROM node:${NODE_VERSION} AS vendor

Expand Down
4 changes: 4 additions & 0 deletions eslint.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
module.exports = {
ignores: ["src/cli.js"],
files: ["**/*.js", "**/*.jsx"]
};
Loading
Loading