Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync-with-PRO workflow #10270

Merged
merged 25 commits into from
May 23, 2024
Merged

sync-with-PRO workflow #10270

merged 25 commits into from
May 23, 2024

Conversation

aryx
Copy link
Collaborator

@aryx aryx commented May 22, 2024

test plan:
trigger from GHA dashboard from this branch and
check if PR created in semgrep-pro

test plan:
trigger from GHA dashboard from this branch and
check if PR created in semgrep-pro
@aryx aryx requested review from a team, IagoAbal and brandonspark and removed request for a team and brandonspark May 22, 2024 15:50
Copy link
Contributor

github-actions bot commented May 22, 2024

PR checklist:

  • Purpose of the code is evident to future readers
  • Tests included or PR comment includes a reproducible test plan
  • Documentation is up-to-date
  • A changelog entry was added to changelog.d for any user-facing change
  • Change has no security implications (otherwise, ping security team)

If you're unsure about any of this, please see:

@r2c-argo
Copy link
Contributor

r2c-argo bot commented May 22, 2024

semgrep-compare-github-6e6vg results

Ran benchmark on 38 repositories

The number of findings differs for 1 repos

Whole benchmark is 0.1% slower (a bit of noise is expected)

Relative speed improvement is 1.02 on average

Relative memory improvement is 1.00 on average

@r2c-argo
Copy link
Contributor

r2c-argo bot commented May 22, 2024

semgrep-compare-github-ptqf7 results

Ran benchmark on 38 repositories

The number of files checked differs for 1 repos

The number of findings differs for 3 repos

Whole benchmark is 7.3% slower (a bit of noise is expected)

Relative speed improvement is 1.00 on average

  • 3% of scans are significantly slower

Relative memory improvement is 1.00 on average

@aryx aryx merged commit fce31df into develop May 23, 2024
53 checks passed
@aryx aryx deleted the sync_with_pro branch May 23, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants