Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new option for appending a build suffix to prereleases #1894

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adambullmer
Copy link

@adambullmer adambullmer commented Apr 16, 2021

Fixes: #1793

Usage updates mostly cover this, but the intent is to allow users the ability to append +build information to the releases. This hook should enable many other workflows at minimal effort or maintenance on this tool.

In my case, we rebase all feature branches from main, and this causes prerelease conflicts

@adambullmer adambullmer force-pushed the master branch 3 times, most recently from c2be4db to 1e1459d Compare April 16, 2021 17:47
@shihfu
Copy link

shihfu commented Sep 9, 2022

Hello, what is the status of this pull request?

I'm running into this exact issue /w rebasing pre-release branches.

@mamachanko
Copy link
Contributor

The suggested approach appears to limit optional addition of build metadata to prereleases. However, I would find it helpful if they wouldn't be limited to pre-releases. After all, 1.2.3+stuff is a valid and reasonable semver as per spec.

@chrisEff
Copy link

chrisEff commented Mar 8, 2023

I need exactly this feature. I'd gladly review it myself if I were familiar with the project's code/structure enough to do so, but unfortunately I'm not. So I would be VERY grateful if someone from the main contributors could take a look at this...

@ThommyH
Copy link

ThommyH commented Oct 25, 2023

we also need this, is there a plan to merge that in?

@JTeeuwissen
Copy link

Bump, this would be very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improved handling of rebases on pre-release branches
7 participants