Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make success comments filterable #360

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

balazsorban44
Copy link

Fixes #359

@jpsullivan
Copy link

I know this isn't particularly helpful, but my team has been running into this as well, and would love to see this merged in. If there's anything I can do to assist, please feel free to let me know!

Copy link

@oljp oljp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However I do think that documentation should be included for this filter as well.

@balazsorban44
Copy link
Author

Of course! I can do, that, if you point me to the right place. 😊

@oljp
Copy link

oljp commented May 25, 2021

I'm not an official maintainer, though if I were to assume I'd go ahead and drop the successFilter into the Options category of the README. https://github.com/semantic-release/github/blob/master/README.md#options, providing a brief description and maybe some example values.

@gr2m
Copy link
Member

gr2m commented May 25, 2021

sorry for the delay with reviewing PRs. We are all pretty swamped right now, but how to find time to review the open PRs and onboard new maintainers soon

@raffis
Copy link

raffis commented Nov 4, 2022

Any reason this is not merged? Currently I have the problem that if semantic-release with github gets added to an old repo with thousands of merged pr's, you end up with thousands of comments done by semantic-release. I wonder why this was not yet mentioned anywhere.
A filter would help in this case, we could add the released label manually to all merged pr's before introducing semantic-release.
Alternative solution might also the ability to specify a custom github search query.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter PR/Issue that should get a comment on success
5 participants