Skip to content

Commit

Permalink
feat(node-versions): raised the minimum required node version to v18
Browse files Browse the repository at this point in the history
BREAKING CHANGE: the minimum required version of node is now v18

for #247
  • Loading branch information
travi committed Jun 7, 2023
1 parent 7df5e62 commit 7b48ffd
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 8 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/release.yml
Expand Up @@ -23,7 +23,8 @@ jobs:
with:
cache: npm
node-version: lts/*
- run: npm ci
- run: npm clean-install
- run: npm audit signatures
- run: npx semantic-release
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down
15 changes: 10 additions & 5 deletions .github/workflows/test.yml
Expand Up @@ -16,8 +16,9 @@ jobs:
strategy:
matrix:
node-version:
- 14.17
- 16
- 18.0.0
- 19
- 20

runs-on: ubuntu-latest

Expand All @@ -28,7 +29,8 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
cache: npm
- run: npm ci
- run: npm clean-install
- run: npm audit signatures
- run: npm run test:ci

# separate job to set as required in branch protection,
Expand All @@ -40,9 +42,12 @@ jobs:
- uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab # v3
- uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3
with:
node-version: 16
node-version: lts/*
cache: npm
- run: npm ci
- run: npm clean-install
- name: Ensure dependencies are compatible with the version of node
run: npx ls-engines
- run: npm run lint
# https://github.com/lirantal/lockfile-lint#readme
- name: Scan lockfile for security issues
run: npx lockfile-lint --path package-lock.json
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -19,7 +19,7 @@
"xo": "0.39.1"
},
"engines": {
"node": ">=14.17"
"node": ">=18"
},
"files": [
"index.js"
Expand Down

0 comments on commit 7b48ffd

Please sign in to comment.