This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code dup #33
base: master
Are you sure you want to change the base?
Code dup #33
Changes from all commits
d35388c
678ccee
bc0ad63
2154475
8fb5f1f
c030ec6
0b7147d
376a53c
406a762
1b93264
29ca346
c97dfac
69d5b6f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have some differences here.
Code here is
def send(self, cmd)
, but in parent class isasync def send(self, cmd)
. We need to do the same for removing the ambiguous.I think that we can leave it a regular function like asyncssh's authors and asyncio's authors made it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same thing like in here.
I'd prefer to leave it as a regular function, not a coroutine.