Improved smart pointer usages to KniDevice and DpdkDevice.

[Dimi1010]

This PR rewrites some functions that were using manual lifetime tracking with std::unique_ptr.

[seladb]

@Dimi1010 did you have a chance to run the DPDK test locally?
Unfortunately, the CI doesn't run them because setting up DPDK in CI is not easy, so we need to run them locally...

[Dimi1010]

@Dimi1010 did you have a chance to run the DPDK test locally? Unfortunately, the CI doesn't run them because setting up DPDK in CI is not easy, so we need to run them locally...

Unfortunately, no. :/ I mostly have it setup to validate it can build, but unsure how, or even if it can be setup to run on WSL, and I don't have a bare-metal Unix OS currently.

[seladb]

@Dimi1010 did you have a chance to run the DPDK test locally? Unfortunately, the CI doesn't run them because setting up DPDK in CI is not easy, so we need to run them locally...

Unfortunately, no. :/ I mostly have it setup to validate it can build, but unsure how, or even if it can be setup to run on WSL, and I don't have a bare-metal Unix OS currently.

I don't think DPDK can run in WSL 😕
I also don't have a bare-metal Linux device, but I have Ubuntu running inside a VirtualBox VM, and DPDK can be easily set up there. Do you think you can set one up? If not, I can test it on my VM...

[Dimi1010]

@Dimi1010 did you have a chance to run the DPDK test locally? Unfortunately, the CI doesn't run them because setting up DPDK in CI is not easy, so we need to run them locally...

Unfortunately, no. :/ I mostly have it setup to validate it can build, but unsure how, or even if it can be setup to run on WSL, and I don't have a bare-metal Unix OS currently.

I don't think DPDK can run in WSL 😕 I also don't have a bare-metal Linux device, but I have Ubuntu running inside a VirtualBox VM, and DPDK can be easily set up there. Do you think you can set one up? If not, I can test it on my VM...

Sure, I can try to set one up, if you know it can run there. :)

[seladb]

Sure, I can try to set one up, if you know it can run there. :)

You can follow the instructions here: https://pcapplusplus.github.io/docs/dpdk
It's a good opportunity to see if these instructions are accurate, up to date, and clear 🙂

[seladb]

BTW, maybe at some point we need to figure out how to run DPDK tests in CI, but I gave some thought to it and it won't be easy...

[Dimi1010]

Sure, I can try to set one up, if you know it can run there. :)

You can follow the instructions here: https://pcapplusplus.github.io/docs/dpdk It's a good opportunity to see if these instructions are accurate, up to date, and clear 🙂

the docs still say we test against ubuntu 20.04 and 22.04 when the CI runs on 22.04 and 24.04