Added internal::DeviceListBase as a common base for device list classes.
#1790
Conversation
Dimi1010
changed the title
internal::DeviceListBase as a common base for all device list classes.internal::DeviceListBase as a common base for device list classes.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1790 +/- ##
==========================================
+ Coverage 83.05% 83.08% +0.03%
==========================================
Files 283 284 +1
Lines 48973 48981 +8
Branches 10333 10358 +25
==========================================
+ Hits 40675 40698 +23
+ Misses 7157 7140 -17
- Partials 1141 1143 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pcap++/header/DeviceListBase.h
Outdated
| using value_type = T*; | ||
| using size_type = std::size_t; | ||
| using difference_type = std::ptrdiff_t; |
There was a problem hiding this comment.
Mostly to mimic standard container. Originally there were other accessor methods beside the iterator, but I cut those from this PR, so they aren't used atm.
There was a problem hiding this comment.
I'm not sure we need them but I don't have a strong opinion so I'll let you decide
There was a problem hiding this comment.
I guess we can remove them and readd them later if needed.
Split of #1488
Overview of changes:
internal::DeviceListBasethat provides storage and common iterator API for a list of devices.PcapLiveDeviceListto utilizeinternal::DeviceListBase.