Skip to content

Added a custom deleter extension point to PointerVector. #1787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025

Conversation

Dimi1010
Copy link
Collaborator

Split of #1488

The Deleter extension point mirrors std::unique_ptr<T, Deleter>'s API, to allow integration of custom deleter with PointerVector<T>

Copy link

codecov bot commented Apr 24, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.09%. Comparing base (f842ccb) to head (349c7a5).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
Common++/header/PointerVector.h 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1787      +/-   ##
==========================================
- Coverage   83.10%   83.09%   -0.01%     
==========================================
  Files         283      283              
  Lines       48937    48937              
  Branches    10567    10540      -27     
==========================================
- Hits        40668    40666       -2     
- Misses       7113     7137      +24     
+ Partials     1156     1134      -22     
Flag Coverage Δ
alpine320 75.08% <33.33%> (-0.01%) ⬇️
fedora42 75.20% <33.33%> (-0.01%) ⬇️
macos-13 80.61% <66.66%> (+<0.01%) ⬆️
macos-14 80.61% <66.66%> (+<0.01%) ⬆️
macos-15 80.58% <66.66%> (+<0.01%) ⬆️
mingw32 70.74% <33.33%> (-0.04%) ⬇️
mingw64 70.73% <33.33%> (-0.02%) ⬇️
npcap 85.06% <66.66%> (-0.02%) ⬇️
rhel94 74.95% <33.33%> (-0.01%) ⬇️
ubuntu2004 58.55% <33.33%> (-0.03%) ⬇️
ubuntu2004-zstd 58.67% <33.33%> (-0.03%) ⬇️
ubuntu2204 74.90% <33.33%> (-0.01%) ⬇️
ubuntu2204-icpx 61.52% <66.66%> (+<0.01%) ⬆️
ubuntu2404 75.15% <33.33%> (-0.01%) ⬇️
ubuntu2404-arm64 75.12% <33.33%> (-0.01%) ⬇️
unittest 83.09% <66.66%> (-0.01%) ⬇️
windows-2019 85.08% <66.66%> (-0.01%) ⬇️
windows-2022 85.11% <66.66%> (-0.01%) ⬇️
winpcap 85.26% <66.66%> (ø)
xdp 50.58% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Dimi1010 Dimi1010 marked this pull request as ready for review April 24, 2025 09:01
@Dimi1010 Dimi1010 requested a review from seladb as a code owner April 24, 2025 09:01
@Dimi1010 Dimi1010 merged commit 970d641 into seladb:dev Apr 25, 2025
42 checks passed
@Dimi1010 Dimi1010 deleted the feature/pointer-vector-deleter branch April 25, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants