Skip to content

Moved setFilter pcap implementation to PcapHandle. #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025

Conversation

Dimi1010
Copy link
Collaborator

This PR moves the implementation of IPcapDevice::setFilter to PcapHandle::setFilter in a move to encapsulate common pcap operations on the handle under the PcapHandle wrapper.

Copy link

codecov bot commented Mar 28, 2025

Codecov Report

Attention: Patch coverage is 72.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 83.20%. Comparing base (5b6a51c) to head (223505b).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
Pcap++/src/PcapDevice.cpp 72.00% 4 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1752      +/-   ##
==========================================
- Coverage   83.21%   83.20%   -0.01%     
==========================================
  Files         282      282              
  Lines       48719    48730      +11     
  Branches    10547    10330     -217     
==========================================
+ Hits        40540    40546       +6     
+ Misses       7052     7044       -8     
- Partials     1127     1140      +13     
Flag Coverage Δ
alpine320 75.20% <31.57%> (-0.01%) ⬇️
fedora40 75.24% <31.57%> (-0.02%) ⬇️
macos-13 80.71% <52.17%> (-0.01%) ⬇️
macos-14 80.71% <52.17%> (-0.01%) ⬇️
macos-15 80.68% <52.17%> (-0.01%) ⬇️
mingw32 70.86% <26.31%> (-0.04%) ⬇️
mingw64 70.82% <26.31%> (-0.04%) ⬇️
npcap 85.23% <68.18%> (-0.09%) ⬇️
rhel94 75.07% <31.57%> (-0.03%) ⬇️
ubuntu2004 58.64% <31.57%> (+0.02%) ⬆️
ubuntu2004-zstd 58.73% <31.57%> (-0.03%) ⬇️
ubuntu2204 74.99% <31.57%> (-0.04%) ⬇️
ubuntu2204-icpx 61.37% <34.78%> (+<0.01%) ⬆️
ubuntu2404 75.24% <31.57%> (-0.04%) ⬇️
unittest 83.20% <72.00%> (-0.01%) ⬇️
windows-2019 85.33% <68.18%> (-0.02%) ⬇️
windows-2022 85.36% <68.18%> (-0.02%) ⬇️
winpcap 85.32% <68.18%> (-0.01%) ⬇️
xdp 50.68% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Dimi1010 Dimi1010 marked this pull request as ready for review March 28, 2025 11:54
@Dimi1010 Dimi1010 requested a review from seladb as a code owner March 28, 2025 11:54
@Dimi1010 Dimi1010 merged commit dfdae49 into seladb:dev Mar 31, 2025
41 checks passed
@Dimi1010 Dimi1010 deleted the refactor/pcap-device-filter-extract branch March 31, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants