Skip to content

Replaced raw array of pointers with std::vector. #1751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 30, 2025

Conversation

Dimi1010
Copy link
Collaborator

No description provided.

@Dimi1010 Dimi1010 requested a review from seladb as a code owner March 28, 2025 09:36
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.20%. Comparing base (5b6a51c) to head (dfa65f2).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1751      +/-   ##
==========================================
- Coverage   83.21%   83.20%   -0.01%     
==========================================
  Files         282      282              
  Lines       48719    48719              
  Branches    10547    10548       +1     
==========================================
- Hits        40540    40539       -1     
+ Misses       7052     7051       -1     
- Partials     1127     1129       +2     
Flag Coverage Δ
alpine320 75.20% <ø> (ø)
fedora40 75.22% <ø> (-0.04%) ⬇️
macos-13 80.71% <ø> (ø)
macos-14 80.71% <ø> (ø)
macos-15 80.68% <ø> (ø)
mingw32 70.85% <ø> (-0.04%) ⬇️
mingw64 70.82% <ø> (-0.04%) ⬇️
npcap 85.30% <ø> (-0.02%) ⬇️
rhel94 75.12% <ø> (+0.01%) ⬆️
ubuntu2004 58.61% <ø> (ø)
ubuntu2004-zstd 58.73% <ø> (-0.03%) ⬇️
ubuntu2204 74.99% <ø> (-0.04%) ⬇️
ubuntu2204-icpx 61.41% <ø> (+0.03%) ⬆️
ubuntu2404 75.27% <ø> (-0.01%) ⬇️
unittest 83.20% <ø> (-0.01%) ⬇️
windows-2019 85.33% <ø> (-0.01%) ⬇️
windows-2022 85.36% <ø> (-0.01%) ⬇️
winpcap 85.33% <ø> (ø)
xdp 50.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@tigercosmos tigercosmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tigercosmos tigercosmos merged commit 7c78bac into seladb:dev Mar 30, 2025
41 checks passed
@Dimi1010 Dimi1010 deleted the refactor/vector-descriptors branch March 30, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants