Skip to content

STRATCONN-6600 - [Dv360] - new action to handle add + remove audience membership#3696

Open
joe-ayoub-segment wants to merge 2 commits intomainfrom
dv360-audience-membership
Open

STRATCONN-6600 - [Dv360] - new action to handle add + remove audience membership#3696
joe-ayoub-segment wants to merge 2 commits intomainfrom
dv360-audience-membership

Conversation

@joe-ayoub-segment
Copy link
Copy Markdown
Contributor

This PR adds a new syncAudience action to the Display & Video 360 destination that handles both audience additions and removals in a single action, replacing the need to use separate addToAudience and removeFromAudience actions.

It leverages actions-core audienceMembership array to fan out a single batch into separate add and remove requests.

Testing

Added multiple unit tests to cover new functionality.
To be tested in Staging.

Security Review

Please ensure sensitive data is properly protected in your integration.

  • Reviewed all field definitions for sensitive data (API keys, tokens, passwords, client secrets) and confirmed they use type: 'password'

New Destination Checklist

  • Extracted all action API versions to verioning-info.ts file. example

@github-actions
Copy link
Copy Markdown
Contributor

New required fields detected

Warning

Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production.

The following required fields were added in this PR:

  • Destination: Display and Video 360 (Actions), Action Field(s):enable_batching,external_audience_id

Add these new fields as optional instead and assume default values in perform or performBatch block.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 97.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.70%. Comparing base (b04de04) to head (5e5336e).

Files with missing lines Patch % Lines
...stinations/display-video-360/syncAudience/index.ts 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3696      +/-   ##
==========================================
- Coverage   80.88%   80.70%   -0.19%     
==========================================
  Files        1383     1327      -56     
  Lines       27609    24677    -2932     
  Branches     5931     5090     -841     
==========================================
- Hits        22331    19915    -2416     
+ Misses       4323     3829     -494     
+ Partials      955      933      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant