STRATCONN-6600 - [Dv360] - new action to handle add + remove audience membership#3696
Open
joe-ayoub-segment wants to merge 2 commits intomainfrom
Open
STRATCONN-6600 - [Dv360] - new action to handle add + remove audience membership#3696joe-ayoub-segment wants to merge 2 commits intomainfrom
joe-ayoub-segment wants to merge 2 commits intomainfrom
Conversation
Contributor
New required fields detectedWarning Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production. The following required fields were added in this PR:
Add these new fields as optional instead and assume default values in |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3696 +/- ##
==========================================
- Coverage 80.88% 80.70% -0.19%
==========================================
Files 1383 1327 -56
Lines 27609 24677 -2932
Branches 5931 5090 -841
==========================================
- Hits 22331 19915 -2416
+ Misses 4323 3829 -494
+ Partials 955 933 -22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
syncAudienceaction to the Display & Video 360 destination that handles both audience additions and removals in a single action, replacing the need to use separate addToAudience and removeFromAudience actions.It leverages actions-core audienceMembership array to fan out a single batch into separate add and remove requests.
Testing
Added multiple unit tests to cover new functionality.
To be tested in Staging.
Security Review
Please ensure sensitive data is properly protected in your integration.
type: 'password'New Destination Checklist
verioning-info.tsfile. example