Skip to content

Fix CI Snyk vulnerabilities in liquidjs and fast-xml-parser#3686

Draft
Copilot wants to merge 3 commits intomainfrom
copilot/fix-ci-snyk-issue
Draft

Fix CI Snyk vulnerabilities in liquidjs and fast-xml-parser#3686
Copilot wants to merge 3 commits intomainfrom
copilot/fix-ci-snyk-issue

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 24, 2026

Snyk CI check failing due to high-severity vulnerabilities in liquidjs@10.12.0 and fast-xml-parser@5.3.4.

Changes

  • liquidjs: Bump from ^10.8.4 to ^10.25.0 across all packages

  • fast-xml-parser: Add yarn resolution to force 5.5.9

    • Transitive dependency via @aws-sdk/*
    • Fixes XML Entity Expansion and regex DoS vulnerabilities
"resolutions": {
  "fast-xml-parser": "5.5.9"
}

All existing liquidjs tests pass.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • formulae.brew.sh
    • Triggering command: /bin/curl /bin/curl -q --fail --compressed --silent --speed-limit 100 --speed-time 5 --location --remote-time --output /home/REDACTED/.cache/Homebrew/api/formula.jws.json --user-agent Linuxbrew/5.1.1 (Linux; x86_64 Ubuntu 24.04.3 LTS) curl/8.5.0 REDACTED user.email l/config (dns block)
    • Triggering command: /bin/curl /bin/curl -q --fail --compressed --silent --speed-limit 100 --speed-time 5 --location --remote-time --output /home/REDACTED/.cache/Homebrew/api/cask.jws.json --user-agent Linuxbrew/5.1.1 (Linux; x86_64 Ubuntu 24.04.3 LTS) curl/8.5.0 REDACTED user.email lude (dns block)
    • Triggering command: /bin/curl /bin/curl -q --fail --compressed --silent --speed-limit 100 --speed-time 5 --location --remote-time --output /home/REDACTED/.cache/Homebrew/api/formula_tap_migrations.jws.json --user-agent Linuxbrew/5.1.1 (Linux; x86_64 Ubuntu 24.04.3 LTS) curl/8.5.0 REDACTED user.email lude (dns block)
  • https://api.github.com/repos/Homebrew/brew/tags
    • Triggering command: /bin/curl /bin/curl -q --silent --max-time 3 --location --no-remote-time --output /dev/null --write-out %{http_code} --dump-header /home/linuxbrew/.linuxbrew/Homebrew/.git/GITHUB_HEADERS --user-agent Linuxbrew/5.1.1 (Linux; x86_64 Ubuntu 24.04.3 LTS) curl/8.5.0 --header X-GitHub-Api-Version:2022-11-28 --header Accept: application/vnd.github+json --header (http block)

If you need me to access, download, or install something from one of these locations, you can either:


⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.

…l-parser resolution

- Update liquidjs from ^10.8.4 to ^10.25.0 in packages/actions-shared
- Update liquidjs from ^10.8.4 to ^10.25.0 in packages/destination-actions
- Update liquidjs from ^10.21.0 to ^10.25.0 in root package.json
- Add fast-xml-parser resolution to 5.5.9 for AWS SDK transitive dependency

Fixes:
- SNYK-JS-LIQUIDJS-15443434: Directory Traversal (High Severity)
- SNYK-JS-FASTXMLPARSER-15307668: XML Entity Expansion (High Severity)
- SNYK-JS-FASTXMLPARSER-15324289: Incorrect Regular Expression (High Severity)
- SNYK-JS-FASTXMLPARSER-15677840: XML Entity Expansion (High Severity)
- SNYK-JS-FASTXMLPARSER-15699647: Improper Validation (High Severity)
Copilot AI changed the title [WIP] Fix CI Snyk issue Fix CI Snyk vulnerabilities in liquidjs and fast-xml-parser Mar 24, 2026
Copilot AI requested a review from itsarijitray March 24, 2026 12:11
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.89%. Comparing base (4aa858f) to head (5a646d5).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3686      +/-   ##
==========================================
+ Coverage   80.83%   80.89%   +0.06%     
==========================================
  Files        1382     1639     +257     
  Lines       27543    31642    +4099     
  Branches     5883     6962    +1079     
==========================================
+ Hits        22264    25598    +3334     
- Misses       4342     5087     +745     
- Partials      937      957      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@itsarijitray itsarijitray marked this pull request as ready for review March 24, 2026 12:41
@itsarijitray itsarijitray requested a review from a team as a code owner March 24, 2026 12:41
Copy link
Copy Markdown
Contributor

@mdkhan-tw mdkhan-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we try exhaustive testing? We had a sev because of liquidjs parsing error

@itsarijitray
Copy link
Copy Markdown
Contributor

Can we try exhaustive testing? We had a sev because of liquidjs parsing error

Yes... This yet to be tested on staging...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants