Skip to content

[Google Campaign Manager 360] Canary Version Upgrade to v5 #3667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harsh-joshi99 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[Google Campaign Manager 360] Canary Version Upgrade to v5 #3667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c2ceb6b
Update API version
harsh-joshi99 Mar 13, 2026
9d54afc
Add feature flag tests and breaking changes analysis for CM360 v5 upg…
harsh-joshi99 Mar 16, 2026
716c4b5
Use exported constants in canary-version tests and remove analysis doc
harsh-joshi99 Mar 23, 2026
4962a2f
Merge branch 'main' into double-click-api-upgrade
harsh-joshi99 Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
141 changes: 132 additions & 9 deletions ...stinations/google-campaign-manager-360/conversionAdjustmentUpload/__tests__/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import nock from 'nock'
import { createTestEvent, createTestIntegration, SegmentEvent } from '@segment/actions-core'
import Destination from '../../index'
import { API_VERSION, CANARY_API_VERSION, FLAGON_NAME } from '../../utils'

const testDestination = createTestIntegration(Destination)
const timestamp = new Date('Thu Jun 10 2024 11:08:04 GMT-0700 (Pacific Daylight Time)').toISOString()
Expand Down Expand Up @@ -42,7 +43,9 @@ describe('CampaignManager360.conversionAdjustmentUpload', () => {

delete event.userId

nock(`https://dfareporting.googleapis.com/dfareporting/v4/userprofiles/${profileId}/conversions/batchupdate`)
nock(
`https://dfareporting.googleapis.com/dfareporting/${API_VERSION}/userprofiles/${profileId}/conversions/batchupdate`
)
.post('')
.reply(200, { results: [{}] })

Expand Down Expand Up @@ -145,7 +148,9 @@ describe('CampaignManager360.conversionAdjustmentUpload', () => {
}
})

nock(`https://dfareporting.googleapis.com/dfareporting/v4/userprofiles/${profileId}/conversions/batchupdate`)
nock(
`https://dfareporting.googleapis.com/dfareporting/${API_VERSION}/userprofiles/${profileId}/conversions/batchupdate`
)
.post('')
.reply(200, { results: [{}] })

Expand Down Expand Up @@ -223,7 +228,9 @@ describe('CampaignManager360.conversionAdjustmentUpload', () => {
}
})

nock(`https://dfareporting.googleapis.com/dfareporting/v4/userprofiles/${profileId}/conversions/batchupdate`)
nock(
`https://dfareporting.googleapis.com/dfareporting/${API_VERSION}/userprofiles/${profileId}/conversions/batchupdate`
)
.post('')
.reply(200, { results: [{}] })

Expand Down Expand Up @@ -288,7 +295,9 @@ describe('CampaignManager360.conversionAdjustmentUpload', () => {

delete event.userId

nock(`https://dfareporting.googleapis.com/dfareporting/v4/userprofiles/${profileId}/conversions/batchupdate`)
nock(
`https://dfareporting.googleapis.com/dfareporting/${API_VERSION}/userprofiles/${profileId}/conversions/batchupdate`
)
.post('')
.reply(200, { results: [{}] })

Expand Down Expand Up @@ -423,7 +432,9 @@ describe('CampaignManager360.conversionAdjustmentUpload', () => {
}
]

nock(`https://dfareporting.googleapis.com/dfareporting/v4/userprofiles/${profileId}/conversions/batchupdate`)
nock(
`https://dfareporting.googleapis.com/dfareporting/${API_VERSION}/userprofiles/${profileId}/conversions/batchupdate`
)
.post('')
.reply(201, { results: [{}] })

Expand Down Expand Up @@ -545,7 +556,9 @@ describe('CampaignManager360.conversionAdjustmentUpload', () => {
}
]

nock(`https://dfareporting.googleapis.com/dfareporting/v4/userprofiles/${profileId}/conversions/batchupdate`)
nock(
`https://dfareporting.googleapis.com/dfareporting/${API_VERSION}/userprofiles/${profileId}/conversions/batchupdate`
)
.post('')
.reply(201, { results: [{}] })

Expand Down Expand Up @@ -640,7 +653,9 @@ describe('CampaignManager360.conversionAdjustmentUpload', () => {
}
]

nock(`https://dfareporting.googleapis.com/dfareporting/v4/userprofiles/${profileId}/conversions/batchupdate`)
nock(
`https://dfareporting.googleapis.com/dfareporting/${API_VERSION}/userprofiles/${profileId}/conversions/batchupdate`
)
.post('')
.reply(201, { results: [{}] })

Expand Down Expand Up @@ -996,7 +1011,9 @@ describe('CampaignManager360.conversionAdjustmentUpload', () => {
kind: 'dfareporting#conversionsBatchUpdateResponse'
}

nock(`https://dfareporting.googleapis.com/dfareporting/v4/userprofiles/${profileId}/conversions/batchupdate`)
nock(
`https://dfareporting.googleapis.com/dfareporting/${API_VERSION}/userprofiles/${profileId}/conversions/batchupdate`
)
.post('')
.reply(200, resp200WithErrors)

Expand Down Expand Up @@ -1105,7 +1122,9 @@ describe('CampaignManager360.conversionAdjustmentUpload', () => {

delete event.userId

nock(`https://dfareporting.googleapis.com/dfareporting/v4/userprofiles/${profileId}/conversions/batchupdate`)
nock(
`https://dfareporting.googleapis.com/dfareporting/${API_VERSION}/userprofiles/${profileId}/conversions/batchupdate`
)
.post('')
.reply(401)

Expand Down Expand Up @@ -1182,4 +1201,108 @@ describe('CampaignManager360.conversionAdjustmentUpload', () => {
).rejects.toThrowError('Unauthorized')
})
})

describe('API Version Feature Flag', () => {
it('should use v4 API by default (stable version)', async () => {
const event = createTestEvent({
timestamp,
event: 'Test Event',
properties: {
gclid: 'test-gclid',
value: 100,
quantity: 1,
ordinal: '1'
}
})

nock(
`https://dfareporting.googleapis.com/dfareporting/${API_VERSION}/userprofiles/${profileId}/conversions/batchupdate`
)
.post('')
.reply(200, { results: [{}] })

await expect(
testDestination.testAction('conversionAdjustmentUpload', {
event,
mapping: {
requiredId: {
gclid: {
'@path': '$.properties.gclid'
}
},
timestamp: {
'@path': '$.timestamp'
},
value: {
'@path': '$.properties.value'
},
quantity: {
'@path': '$.properties.quantity'
},
ordinal: {
'@path': '$.properties.ordinal'
}
},
useDefaultMappings: true,
settings: {
profileId,
defaultFloodlightActivityId: floodlightActivityId,
defaultFloodlightConfigurationId: floodlightConfigurationId
}
})
).resolves.not.toThrowError()
})

it('should use v5 API when canary feature flag is enabled', async () => {
const event = createTestEvent({
timestamp,
event: 'Test Event',
properties: {
gclid: 'test-gclid',
value: 100,
quantity: 1,
ordinal: '1'
}
})

// Should call v5 endpoint when feature flag is enabled
nock(
`https://dfareporting.googleapis.com/dfareporting/${CANARY_API_VERSION}/userprofiles/${profileId}/conversions/batchupdate`
)
.post('')
.reply(200, { results: [{}] })

await expect(
testDestination.testAction('conversionAdjustmentUpload', {
event,
mapping: {
requiredId: {
gclid: {
'@path': '$.properties.gclid'
}
},
timestamp: {
'@path': '$.timestamp'
},
value: {
'@path': '$.properties.value'
},
quantity: {
'@path': '$.properties.quantity'
},
ordinal: {
'@path': '$.properties.ordinal'
}
},
useDefaultMappings: true,
settings: {
profileId,
defaultFloodlightActivityId: floodlightActivityId,
defaultFloodlightConfigurationId: floodlightConfigurationId
},
features: { [FLAGON_NAME]: true }
})
).resolves.not.toThrowError()
})
})
})
8 changes: 4 additions & 4 deletions ...-actions/src/destinations/google-campaign-manager-360/conversionAdjustmentUpload/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,11 @@ const action: ActionDefinition<Settings, Payload> = {
},
...commonFields
},
perform: async (request, { settings, payload, auth }) => {
return await send(request, settings, [payload], true, auth)
perform: async (request, { settings, payload, auth, features }) => {
return await send(request, settings, [payload], true, auth, features)
},
performBatch: async (request, { settings, payload, auth }) => {
return await send(request, settings, payload, true, auth)
performBatch: async (request, { settings, payload, auth, features }) => {
return await send(request, settings, payload, true, auth, features)
}
}

Expand Down
Loading
Loading