Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node upgrade #2706

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Node upgrade #2706

wants to merge 12 commits into from

Conversation

sayan-das-in
Copy link
Contributor

Upgrade node version to 20.18

Testing

Testing in progress.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.26%. Comparing base (56e9fc2) to head (4132911).

Files with missing lines Patch % Lines
...nations/pipedrive/pipedriveApi/pipedrive-client.ts 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2706      +/-   ##
==========================================
+ Coverage   78.56%   79.26%   +0.70%     
==========================================
  Files        1036     1284     +248     
  Lines       18767    24682    +5915     
  Branches     3563     5109    +1546     
==========================================
+ Hits        14744    19565    +4821     
- Misses       2822     3910    +1088     
- Partials     1201     1207       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sayan-das-in sayan-das-in deleted the node-upgrade branch February 5, 2025 11:12
@sayan-das-in sayan-das-in restored the node-upgrade branch February 5, 2025 11:17
@sayan-das-in sayan-das-in reopened this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant