-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STRAT-5398 | Klaviyo(Actions) |Allow user to configure event name and product event name in OrderCompleted Action. #2704
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Left a question.
packages/destination-actions/src/destinations/klaviyo/orderCompleted/index.ts
Outdated
Show resolved
Hide resolved
packages/destination-actions/src/destinations/klaviyo/orderCompleted/index.ts
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2704 +/- ##
==========================================
- Coverage 78.46% 78.45% -0.01%
==========================================
Files 1036 1036
Lines 18771 18773 +2
Branches 3561 3563 +2
==========================================
Hits 14729 14729
Misses 2844 2844
- Partials 1198 1200 +2 ☔ View full report in Codecov by Sentry. |
This Pull request is to allow user to configure Event Name and Product Event Name in OrderCompleted Actions.
Jira ticket:- https://segment.atlassian.net/jira/software/c/projects/STRATCONN/boards/310?assignee=63617339fc0cc7a600b03c6b&selectedIssue=STRATCONN-5398
Tested it in Staging Environment.
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.