Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STRAT-5398 | Klaviyo(Actions) |Allow user to configure event name and product event name in OrderCompleted Action. #2704

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Innovative-GauravKochar
Copy link
Contributor

@Innovative-GauravKochar Innovative-GauravKochar commented Jan 23, 2025

This Pull request is to allow user to configure Event Name and Product Event Name in OrderCompleted Actions.
Jira ticket:- https://segment.atlassian.net/jira/software/c/projects/STRATCONN/boards/310?assignee=63617339fc0cc7a600b03c6b&selectedIssue=STRATCONN-5398

Tested it in Staging Environment.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@Innovative-GauravKochar Innovative-GauravKochar changed the title Strat 5398 STRAT-5398 | Klaviyo(Actions) |Allow user to configure event name and product event name in OrderCompleted Action. Jan 23, 2025
@Innovative-GauravKochar Innovative-GauravKochar marked this pull request as ready for review January 23, 2025 12:09
@Innovative-GauravKochar Innovative-GauravKochar requested a review from a team as a code owner January 23, 2025 12:09
Copy link
Contributor

@varadarajan-tw varadarajan-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Left a question.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.45%. Comparing base (52537f3) to head (95ab8da).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...s/src/destinations/klaviyo/orderCompleted/index.ts 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2704      +/-   ##
==========================================
- Coverage   78.46%   78.45%   -0.01%     
==========================================
  Files        1036     1036              
  Lines       18771    18773       +2     
  Branches     3561     3563       +2     
==========================================
  Hits        14729    14729              
  Misses       2844     2844              
- Partials     1198     1200       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

varadarajan-tw
varadarajan-tw previously approved these changes Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants