-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Braze SDK v5.6 #2687
base: main
Are you sure you want to change the base?
Braze SDK v5.6 #2687
Conversation
Hi @joe-ayoub-segment we have a customer blocked on an integration so appreciate your review on this. Thanks! |
hi @davidbielik the PR makes sense to me. |
If you can provide proof of testing, I can deploy this across Monday and Tuesday ( it takes 2 days to roll out - based on customer tiers). If you like you could provide me with the source IDs for your customer's Sources which are connected to Braze Web Destinations, and I can include them in the Monday roll out (i.e they will get the updated code on Monday rather than Tuesday). |
Thanks @joe-ayoub-segment . I can't my local environment working. Could you install it on my workspace to QA? |
hi @davidbielik cab you please run 'yarn types' and commit the changed files please? |
hi again @davidbielik - this PR is breaking some tests also. Are you OK fixing this please? |
Once you have the test and types fixed I can deploy it to your Workspace. |
@joe-ayoub-segment should be all set now, thanks! |
Adds v5.6 Braze SDK
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.