Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New APIs to destination actions and code improvements #2626

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
f3f55c5
Saving progress
wtnelso Nov 6, 2024
457ecfa
Update packages/destination-actions/src/destinations/attentive/index.ts
wtnelso Nov 12, 2024
c4a3cdb
Update packages/destination-actions/src/destinations/attentive/custom…
wtnelso Nov 12, 2024
2796e25
Update packages/destination-actions/src/destinations/attentive/custom…
wtnelso Nov 12, 2024
12dd973
Update packages/destination-actions/src/destinations/attentive/custom…
wtnelso Nov 12, 2024
63abf12
Update packages/destination-actions/src/destinations/attentive/custom…
wtnelso Nov 12, 2024
dd36acc
Update packages/destination-actions/src/destinations/attentive/custom…
wtnelso Nov 12, 2024
c49dda1
Update packages/destination-actions/src/destinations/attentive/custom…
wtnelso Nov 12, 2024
72ef7a5
Update packages/destination-actions/src/destinations/attentive/custom…
wtnelso Nov 12, 2024
4d872e0
Update packages/destination-actions/src/destinations/attentive/custom…
wtnelso Nov 12, 2024
8b0a24b
Update packages/destination-actions/src/destinations/attentive/custom…
wtnelso Nov 12, 2024
72e079e
Update index.ts
wtnelso Nov 12, 2024
2bf43f9
refacting the fields and request
joe-ayoub-segment Nov 13, 2024
90c6af7
correcting yarn version
joe-ayoub-segment Nov 13, 2024
0e91cb5
minor tweaks
joe-ayoub-segment Nov 13, 2024
ffbfb9b
minor tweaks
joe-ayoub-segment Nov 13, 2024
65eb733
adding types
joe-ayoub-segment Nov 13, 2024
20b8cbe
Update index.test.ts
wtnelso Nov 14, 2024
cc05c0a
Update index.test.ts
wtnelso Nov 14, 2024
76c82d8
Update index.test.ts
wtnelso Nov 14, 2024
48a985f
Update index.test.ts
wtnelso Nov 14, 2024
8faa1d0
adding types
joe-ayoub-segment Nov 15, 2024
4a82258
New endpoints
wtnelso Nov 15, 2024
cbf2af3
added of endpoints
wtnelso Nov 15, 2024
a06e672
resolved conflicts
wtnelso Nov 15, 2024
5eb242d
bug fixes
wtnelso Nov 15, 2024
5aa5d3d
config file added
wtnelso Nov 15, 2024
fd3af7d
index updates
wtnelso Nov 15, 2024
a16c78f
updating snapshot and fixing a field type issue
joe-ayoub-segment Nov 18, 2024
056e5bc
adding a unit test
joe-ayoub-segment Nov 19, 2024
9fce8e1
new unit test
wtnelso Nov 19, 2024
7428f7b
fixing breaking test
joe-ayoub-segment Nov 20, 2024
461a8cf
New endpoints and code improvements
wtnelso Dec 4, 2024
a84383d
Merge branch 'main' into attentive
wtnelso Dec 4, 2024
3393d70
Requsted updates
wtnelso Dec 9, 2024
9a6b8e2
updates
wtnelso Dec 9, 2024
a2f8a8d
Merge branch 'main' into attentive
wtnelso Dec 12, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update packages/destination-actions/src/destinations/attentive/custom…
…Events/index.ts

Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
  • Loading branch information
wtnelso and joe-ayoub-segment authored Nov 12, 2024
commit 63abf1276820df593317f04a4b1c52f259397f59
Original file line number Diff line number Diff line change
@@ -33,7 +33,7 @@ const action: ActionDefinition<Settings, Payload> = {
occurredAt: {
label: 'Occurred At',
description: 'Timestamp of when the action occurred in ISO 8601 format.',
type: 'string', // Keep 'string', as <date-time> is not a valid type in TypeScript.
type: 'string',
required: false,
default: {
'@path': '$.timestamp'