Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT PUSH TO PROD] - syncId as new field #2524

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

mayur-pitale
Copy link
Contributor

A summary of your pull request, including the what change you're making and why.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@mayur-pitale mayur-pitale requested a review from a team as a code owner October 22, 2024 05:57
@seg-atlantis-prod
Copy link

Plan Error

running git merge -q --no-ff -m atlantis-merge FETCH_HEAD: Auto-merging packages/destination-actions/src/destinations/s3/functions.ts
Auto-merging packages/destination-actions/src/destinations/s3/syncToS3/index.ts
CONFLICT (content): Merge conflict in packages/destination-actions/src/destinations/s3/syncToS3/index.ts
Automatic merge failed; fix conflicts and then commit the result.
: exit status 1

@mayur-pitale mayur-pitale merged commit 4f013ec into staging Oct 22, 2024
7 of 13 checks passed
@mayur-pitale mayur-pitale deleted the s3_syncid_new_field branch October 22, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant