Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hubspot] Custom Object V2 - bug fix for textarea field type #2517

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

joe-ayoub-segment
Copy link
Contributor

@joe-ayoub-segment joe-ayoub-segment commented Oct 21, 2024

[Hubspot] Custom Object V2 - bug fix for textarea field type

Testing

See video below which shows reproduction and bug fix:

hubpot.custom.object.textarea.manual.testing.mov
  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 77.99%. Comparing base (09e84ae) to head (80e5760).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ons/src/destinations/hubspot/upsertObject/utils.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2517      +/-   ##
==========================================
- Coverage   78.78%   77.99%   -0.79%     
==========================================
  Files        1052      991      -61     
  Lines       20503    17382    -3121     
  Branches     4228     3274     -954     
==========================================
- Hits        16153    13557    -2596     
+ Misses       3256     2737     -519     
+ Partials     1094     1088       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joe-ayoub-segment joe-ayoub-segment merged commit d8b4597 into main Oct 21, 2024
11 of 15 checks passed
@joe-ayoub-segment joe-ayoub-segment deleted the STRATCONN-4288-hubspot branch October 21, 2024 13:00
@joe-ayoub-segment
Copy link
Contributor Author

PR deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants