Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes failing browser tests by mocking intercom script #2512

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

varadarajan-tw
Copy link
Contributor

@varadarajan-tw varadarajan-tw commented Oct 18, 2024

Browser tests are failing have been failing for a while.
I am not sure whats the root cause but if i mock intercom's load script, it seems to fix everything.

Before

image

Testing

Testing completed via CI.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.18%. Comparing base (09e84ae) to head (254e66e).
Report is 2 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (09e84ae) and HEAD (254e66e). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (09e84ae) HEAD (254e66e)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2512       +/-   ##
===========================================
- Coverage   78.78%   33.18%   -45.60%     
===========================================
  Files        1052       14     -1038     
  Lines       20503      693    -19810     
  Branches     4228      109     -4119     
===========================================
- Hits        16153      230    -15923     
+ Misses       3256      463     -2793     
+ Partials     1094        0     -1094     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@varadarajan-tw varadarajan-tw changed the title Fixes ext workflow - remove ignore-optional Fixes failing browser tests by mocking intercom script Oct 21, 2024
@varadarajan-tw varadarajan-tw marked this pull request as ready for review October 21, 2024 09:28
@varadarajan-tw varadarajan-tw requested review from a team as code owners October 21, 2024 09:28
@varadarajan-tw varadarajan-tw merged commit d9a938e into main Oct 21, 2024
14 of 15 checks passed
@varadarajan-tw varadarajan-tw deleted the remove-ignore-optional branch October 21, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants