Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mantle: add platform plan name option to identify #2502

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

jnormore
Copy link
Contributor

@jnormore jnormore commented Oct 13, 2024

Adds mapping for platformPlanName optional field in the Mantle action.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@jnormore jnormore requested a review from a team as a code owner October 13, 2024 10:16
@seg-atlantis-prod
Copy link

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

@seg-atlantis-prod
Copy link

Error parsing command: EOF found when expecting closing quote

Comment on lines +41 to +47
platformPlanName: {
label: 'Platform Plan Name',
description: 'The name of the plan the customer is on on the platform (Shopify)',
type: 'string',
required: false,
default: { '@path': '$.traits.platformPlanName' }
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jnormore did you intend to add platformPlanName to the request body?

    return request(`${API_URL}/identify`, {
      method: 'post',
      json: {
        platform: 'shopify',
        platformId: data.payload.platformId,
        myshopifyDomain: data.payload.myshopifyDomain,
        name: data.payload.name,
        email: data.payload.email,
        ...(data.payload.customFields ? { customFields: data.payload.customFields } : {})
      }
    })

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😳 sorry! Thanks for the catch, it's fixed now.

@seg-atlantis-prod
Copy link

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

@seg-atlantis-prod
Copy link

Error parsing command: EOF found when expecting closing quote

@joe-ayoub-segment joe-ayoub-segment self-assigned this Oct 16, 2024
@joe-ayoub-segment joe-ayoub-segment merged commit 4ea1ff3 into segmentio:main Oct 16, 2024
11 of 12 checks passed
@joe-ayoub-segment
Copy link
Contributor

hi @jnormore PR deployed. Please confirm that you are happy with the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants