Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PE-103] Update group action to use created_at as a reserved key #2500

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

tcgilbert
Copy link
Contributor

@tcgilbert tcgilbert commented Oct 11, 2024

Currently, our Mixpanel group action only treats the name trait field as a reserved property for Mixpanel.

Screenshot 2024-10-11 at 12 48 23 PM

A customer has raised a concern that they would like the created field to be handled in the same way as name. As currently, when createdAt, created, or created_at are not sent as $created, these fields are added to group profiles as regular profile properties instead of being treated as reserved properties.

The ask from the customer is to update the group action to operate in the same way that the identify action does regarding reserved properties. Similar to this update: #801

image

Testing

before update

Screenshot 2024-10-11 at 12 22 48 PM

after update

Screenshot 2024-10-11 at 12 22 28 PM

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.97%. Comparing base (16ec611) to head (45f25dc).
Report is 20 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2500   +/-   ##
=======================================
  Coverage   77.97%   77.97%           
=======================================
  Files         991      991           
  Lines       17327    17328    +1     
  Branches     3265     3266    +1     
=======================================
+ Hits        13510    13511    +1     
  Misses       2729     2729           
  Partials     1088     1088           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joe-ayoub-segment
Copy link
Contributor

hi @tcgilbert thanks for doing this.
I see no issues with it as it replicates a pre-existing pattern from the identify() Action, and you showed that it tested successfully.

@joe-ayoub-segment joe-ayoub-segment merged commit 42264a1 into main Oct 21, 2024
15 checks passed
@joe-ayoub-segment joe-ayoub-segment deleted the PE-103/mixpanel branch October 21, 2024 13:01
@joe-ayoub-segment
Copy link
Contributor

hi @tcgilbert this PR has been deployed. Please confirm you are happy with the change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants