Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flagon support to Audience methods #2499

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

maryamsharif
Copy link
Contributor

@maryamsharif maryamsharif commented Oct 10, 2024

Adds flagon support to audience methods.

Should be deployed with https://github.com/segmentio/integrations/pull/3021

Testing

Tested by adding flagon to webhooks audience destination and seeing the flagons appear in the call to createAudience.

The family that's accessible to these methods is: centrifuge-destinations.

Screenshot 2024-10-15 at 9 14 21 AM

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@2e9f302). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2499   +/-   ##
=======================================
  Coverage        ?   78.40%           
=======================================
  Files           ?     1044           
  Lines           ?    19897           
  Branches        ?     3997           
=======================================
  Hits            ?    15600           
  Misses          ?     3203           
  Partials        ?     1094           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maryamsharif maryamsharif marked this pull request as ready for review October 15, 2024 16:11
@maryamsharif maryamsharif requested a review from a team as a code owner October 15, 2024 16:11
@maryamsharif maryamsharif merged commit 831215d into main Oct 15, 2024
15 checks passed
@maryamsharif maryamsharif deleted the features-create-audience branch October 15, 2024 16:38
@joe-ayoub-segment
Copy link
Contributor

hi @maryamsharif PR deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants