-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Klaviyo Actions] | Added MultiStatus Batch Support on TrackEvent #2498
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2498 +/- ##
==========================================
- Coverage 78.45% 78.01% -0.44%
==========================================
Files 1044 991 -53
Lines 19945 17436 -2509
Branches 4003 3292 -711
==========================================
- Hits 15647 13602 -2045
+ Misses 3204 2740 -464
Partials 1094 1094 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making this change. The core MultiStatus logic looks good, however I have left some review comments mostly to refactor and simplify the code as these will be listed as examples for external contributors.
As the changes are related to refactoring, please test it once again via unit tests, local and staging after committing the changes just to be sure it doesn't break anything.
packages/destination-actions/src/destinations/klaviyo/trackEvent/index.ts
Outdated
Show resolved
Hide resolved
packages/destination-actions/src/destinations/klaviyo/functions.ts
Outdated
Show resolved
Hide resolved
packages/destination-actions/src/destinations/klaviyo/functions.ts
Outdated
Show resolved
Hide resolved
packages/destination-actions/src/destinations/klaviyo/functions.ts
Outdated
Show resolved
Hide resolved
packages/destination-actions/src/destinations/klaviyo/functions.ts
Outdated
Show resolved
Hide resolved
packages/destination-actions/src/destinations/klaviyo/functions.ts
Outdated
Show resolved
Hide resolved
packages/destination-actions/src/destinations/klaviyo/functions.ts
Outdated
Show resolved
Hide resolved
packages/destination-actions/src/destinations/klaviyo/functions.ts
Outdated
Show resolved
Hide resolved
… actions" This reverts commit bc442a7.
Jira Ticket
This pull request aims to add batch support for the TrackEvent action in Klaviyo(Actions).
Local & Stage Testing Documentation
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.