Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pinterest Audiences] Fix testAuthentication method sample payload. #2465

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

brennan
Copy link
Contributor

@brennan brennan commented Sep 27, 2024

  • Jira ticket: https://segment.atlassian.net/browse/STRATCONN-4167
  • Fixes 422 Unprocessable Entity error when attempting to add new and/or save Pinterest Audiences credentials.
  • Root cause: The event_time parameter in the sample testAuthentication payload was too far in the past, resulting in the following error from Pinterest's API:
{"code":953,"message":"The action could not be processed properly due to some or all data provided being invalid.","details":{"num_events_processed":0,"num_events_received":1,"events":[{"status":"failed","error_message":"Invalid event_timestamp parameter. Given timestamp is in the past. Current timestamp: 1727469267, Given event_timestamp: 1678203524","warning_message":""}]}}

Testing

  • Testing completed locally using testAuthentication method in the actions tester:
Screenshot 2024-09-27 at 1 26 40 PM Screenshot 2024-09-27 at 1 26 48 PM
  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [Segmenters] Tested in the staging environment

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.95%. Comparing base (5a5f52b) to head (5b04552).
Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2465       +/-   ##
===========================================
+ Coverage   33.18%   77.95%   +44.76%     
===========================================
  Files          14      982      +968     
  Lines         693    17030    +16337     
  Branches      109     3194     +3085     
===========================================
+ Hits          230    13275    +13045     
- Misses        463     2687     +2224     
- Partials        0     1068     +1068     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@marinhero marinhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@joe-ayoub-segment joe-ayoub-segment merged commit a7b5504 into main Oct 1, 2024
13 of 14 checks passed
@joe-ayoub-segment joe-ayoub-segment deleted the brennan/pinterest-audiences-test-auth-fix branch October 1, 2024 10:43
@joe-ayoub-segment
Copy link
Contributor

hi @brennan PR deployed. Please confirm you are happy with the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants