Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterable Lists bugfix: cloned response hangs operations between this Destination and Iterable #2461

Merged
merged 6 commits into from
Oct 1, 2024

Conversation

seg-leonelsanches
Copy link
Contributor

With Iterable team, we were able to identify that

hangs operations whose response payload is large, creating timeouts during audience syncs.

This modification solves the problem entirely.

Testing

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [Segmenters] Tested in the staging environment

@seg-leonelsanches seg-leonelsanches marked this pull request as ready for review September 26, 2024 23:21
@seg-leonelsanches seg-leonelsanches requested a review from a team as a code owner September 26, 2024 23:21
@joe-ayoub-segment
Copy link
Contributor

Thanks for raising this @seg-leonelsanches . Please see the comments.
Also it looks like CI checks are failing. Can you take a look please?

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.95%. Comparing base (5a5f52b) to head (070a666).
Report is 11 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2461       +/-   ##
===========================================
+ Coverage   33.18%   77.95%   +44.76%     
===========================================
  Files          14      982      +968     
  Lines         693    17030    +16337     
  Branches      109     3194     +3085     
===========================================
+ Hits          230    13275    +13045     
- Misses        463     2687     +2224     
- Partials        0     1068     +1068     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joe-ayoub-segment joe-ayoub-segment merged commit 6c9dcdd into main Oct 1, 2024
14 checks passed
@joe-ayoub-segment joe-ayoub-segment deleted the iterable-lists-bugfix branch October 1, 2024 11:14
@joe-ayoub-segment
Copy link
Contributor

hi @seg-leonelsanches PR deployed. Please confirm you are happy with the update.

@seg-leonelsanches
Copy link
Contributor Author

Hi @joe-ayoub-segment. I got to test it now. It worked. Thanks for all the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants