Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[google sheets] mark batch_size and batch_bytes are non-required field #2405

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[google sheets] mark batch_size and batch_bytes are non-required field #2405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/destination-actions/src/destinations/google-sheets-dev/postSheet.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ export interface Payload {
/**
* The number of rows to write to the spreadsheet in a single batch. The value is determined by number of rows * columns that Segment can upload within 30s.
*/
batch_size: number
batch_size?: number
/**
* The number of bytes to write to the spreadsheet in a single batch. Limit is 2MB.
*/
batch_bytes: number
batch_bytes?: number
}
4 changes: 2 additions & 2 deletions packages/destination-actions/src/destinations/google-sheets/postSheet/generated-types.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 7 additions & 7 deletions packages/destination-actions/src/destinations/google-sheets/postSheet/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,14 +57,14 @@ const action: ActionDefinition<Settings, Payload> = {
fields: {
label: 'Fields',
description: `
The fields to write to the spreadsheet.
The fields to write to the spreadsheet.

On the left-hand side, input the name of the field as it will appear in the Google Sheet.

On the left-hand side, input the name of the field as it will appear in the Google Sheet.

On the right-hand side, select the field from your data model that maps to the given field in your sheet.

---

`,
type: 'object',
required: true,
Expand All @@ -82,15 +82,15 @@ const action: ActionDefinition<Settings, Payload> = {
description:
'The number of rows to write to the spreadsheet in a single batch. The value is determined by number of rows * columns that Segment can upload within 30s.',
default: 1001,
required: true,
required: false,
unsafe_hidden: true
},
batch_bytes: {
type: 'number',
label: 'Batch Bytes',
description: 'The number of bytes to write to the spreadsheet in a single batch. Limit is 2MB.',
default: 2000000, // 2MB,
required: true,
required: false,
unsafe_hidden: true
}
},
Expand Down
4 changes: 2 additions & 2 deletions packages/destination-actions/src/destinations/google-sheets/postSheet2/generated-types.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/destination-actions/src/destinations/google-sheets/postSheet2/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,15 +94,15 @@ const action: ActionDefinition<Settings, Payload> = {
description:
'The number of rows to write to the spreadsheet in a single batch. The value is determined by number of rows * columns that Segment can upload within 30s.',
default: 1001,
required: true,
required: false,
unsafe_hidden: true
},
batch_bytes: {
type: 'number',
label: 'Batch Bytes',
description: 'The number of bytes to write to the spreadsheet in a single batch. Limit is 2MB.',
default: 2000000, // 2MB,
required: true,
required: false,
unsafe_hidden: true
}
},
Expand Down
Loading