-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per Google, GCLID, GBRAID and WBRAID can't be used at the same time. #2365
base: main
Are you sure you want to change the base?
Per Google, GCLID, GBRAID and WBRAID can't be used at the same time. #2365
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2365 +/- ##
===========================================
+ Coverage 33.18% 77.95% +44.76%
===========================================
Files 14 982 +968
Lines 693 17034 +16341
Branches 109 3196 +3087
===========================================
+ Hits 230 13279 +13049
- Misses 463 2687 +2224
- Partials 0 1068 +1068 ☔ View full report in Codecov by Sentry. |
…s-gclid-gbraid-wbraid
...tination-actions/src/destinations/google-enhanced-conversions/uploadClickConversion/index.ts
Outdated
Show resolved
Hide resolved
…conversions/uploadClickConversion/index.ts Co-authored-by: Joe Ayoub <[email protected]>
hi @brennan - got a small PR for a change to 2 Actions in Google Enhanced Conversions, raised by @seg-leonelsanches from the SA team. Could you triage please? |
Hi @seg-leonelsanches, thanks for raising this PR. Please provide:
|
@brennan This has been problematic when using the Google Ads destination. You can only send one of gclid, gbraid, or wbraid. But Google will append one or more on the ad final URL. Google's code example shows the following logic: # Sets the single specified ID field.
if gclid:
click_conversion.gclid = gclid
elif gbraid:
click_conversion.gbraid = gbraid
else:
click_conversion.wbraid = wbraid This is the error you get from the mapping event tester: There's no impact in adding this change, customers events are already failing if more than one parameter is being sent. In addition, this PR doesn't address another issue where if a Error messages:
|
Per Google:
Our integration allows a customer to send all the three parameters together, resulting in cryptic errors in the destination.
Testing