Google Campaign Manager 360

[seg-leonelsanches]

Google Campaign Manager 360 Action Destination. It works primarily with Conversion endpoints:

• https://developers.google.com/doubleclick-advertisers/rest/v4/conversions/batchinsert
• https://developers.google.com/doubleclick-advertisers/rest/v4/conversions/batchupdate

Testing

To be able to test it, a user should have:

• Proper permissions in Campaign Manager 360, with the scopes: https://www.googleapis.com/auth/ddmconversions https://www.googleapis.com/auth/dfareporting https://www.googleapis.com/auth/dfatrafficking
• At least one profile ID;
• At least one Floodlight Activity ID;
• At least one Floodlight Configuration ID.

To test this integration locally, I used Postman to go through the OAuth2 flow required to generate an access token. Therefore, I can use the token to test calls in https://app.segment.com/dev-center/actions-tester.

• Added unit tests for new functionality
• Tested end-to-end using the local server
• [Segmenters] Tested in the staging environment

[codecov]

Codecov Report

Attention: Patch coverage is 83.47826% with 19 lines in your changes missing coverage. Please review.

Project coverage is 83.15%. Comparing base (22db090) to head (b50515a).
Report is 46 commits behind head on main.

Files with missing lines	Patch %	Lines
...ons/src/destinations/campaign-manager-360/utils.ts	78.16%	9 Missing and 10 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2298      +/-   ##
==========================================
+ Coverage   78.39%   83.15%   +4.76%     
==========================================
  Files         952      931      -21     
  Lines       17627    16186    -1441     
  Branches     3450     3034     -416     
==========================================
- Hits        13818    13460     -358     
+ Misses       2849     2535     -314     
+ Partials      960      191     -769     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[joe-ayoub-segment]

hi @seg-leonelsanches thanks for raising this PR. cc @smultani

This is the first I've heard of this new Integration so we're going to have to check if the Product team are OK with it being built, then go through the usual checks to see if the Integration has been optimally designed and built...

I see there's a meeting scheduled to discuss this on Friday - I've invited Sharan as well. Perhaps there's some planning details on this I'm not yet aware of which can be shared?

Thanks,
Joe

[joe-ayoub-segment]

hi @seg-leonelsanches any chance you could remove all those nx/cache files from the PR please?

[joe-ayoub-segment]

Hi @seg-leonelsanches did you test the Actions end to end? Do they work?
It was a pretty big refactor I did, so want to be sure it still behaves as you need.

[seg-leonelsanches]

Hi @seg-leonelsanches did you test the Actions end to end? Do they work? It was a pretty big refactor I did, so want to be sure it still behaves as you need.

Hi @joe-ayoub-segment. Yes, I tested it today and we are good to go.

[joe-ayoub-segment]

hi @seg-leonelsanches - I added some additional validation with this commit. It's broken some of the tests though. Can you take a look please and make sure that the validation is correct?

Other than that I think this is ready to go live.

We'll need to you to support this until it is in GA. So bug fixes, questions, etc will go to you. Are you OK with this?

[seg-leonelsanches]

hi @seg-leonelsanches - I added some additional validation with this commit. It's broken some of the tests though. Can you take a look please and make sure that the validation is correct?

Other than that I think this is ready to go live.

We'll need to you to support this until it is in GA. So bug fixes, questions, etc will go to you. Are you OK with this?

Done.

Yes, I'll support this destination until GA.

[joe-ayoub-segment]

PR deployed