Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STRATCONN-4101 & STRATCONN - 4099] Update Amazon Ads Hashing #2297

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rvadera12
Copy link
Contributor

@rvadera12 rvadera12 commented Aug 15, 2024

This PR updates the hashing methods to align with the amazon ads data format requirements. https://advertising.amazon.com/help/GCCXMZYCK4RXWS6C

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [Segmenters] Tested in the staging environment

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@c5b6298). Learn more about missing BASE report.

Files Patch % Lines
...estinations/amazon-amc/syncAudiencesToDSP/index.ts 93.54% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2297   +/-   ##
=======================================
  Coverage        ?   77.43%           
=======================================
  Files           ?      901           
  Lines           ?    15413           
  Branches        ?     2812           
=======================================
  Hits            ?    11935           
  Misses          ?     2558           
  Partials        ?      920           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rvadera12 rvadera12 changed the title Rajul/amazon ads email hashing [STRATCONN-4101 & STRATCONN - 4099] Update Amazon Ads Hashing Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants