-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evolv dest actions #2178
Evolv dest actions #2178
Conversation
hi @rcowin thanks for raising this PR. I'll schedule for review. |
packages/browser-destinations/destinations/evolv-ai/src/identifyUser/index.ts
Outdated
Show resolved
Hide resolved
packages/browser-destinations/destinations/evolv-ai/src/identifyUser/index.ts
Outdated
Show resolved
Hide resolved
packages/browser-destinations/destinations/evolv-ai/src/index.ts
Outdated
Show resolved
Hide resolved
packages/browser-destinations/destinations/evolv-ai/src/index.ts
Outdated
Show resolved
Hide resolved
packages/browser-destinations/destinations/evolv-ai/src/index.ts
Outdated
Show resolved
Hide resolved
packages/browser-destinations/destinations/evolv-ai/src/index.ts
Outdated
Show resolved
Hide resolved
packages/browser-destinations/destinations/evolv-ai/src/trackEvent/index.ts
Outdated
Show resolved
Hide resolved
packages/browser-destinations/destinations/evolv-ai/src/trackEvent/index.ts
Outdated
Show resolved
Hide resolved
packages/browser-destinations/destinations/evolv-ai/src/trackEvent/index.ts
Outdated
Show resolved
Hide resolved
packages/browser-destinations/destinations/evolv-ai/src/trackEvent/index.ts
Outdated
Show resolved
Hide resolved
packages/browser-destinations/destinations/evolv-ai/src/trackEvent/index.ts
Outdated
Show resolved
Hide resolved
packages/browser-destinations/destinations/evolv-ai/src/types.ts
Outdated
Show resolved
Hide resolved
Hi @rcowin - thanks for raising the PR. I didn't have time to do a proper review yet. I just scanned through the labels and descriptions and left some comments. Best regards, |
Oh yes @rcowin please note that some CI checks are failing. Could you take a look at this also? |
@tcgilbert build should be fixed. sorry - one of the files had incomplete update. |
How do other optimization tools (VWO and Optimizely) send experiment confirmation events (or do they) as well as consume segment content? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of changes to make.
@joe-ayoub-segment and I went over this PR again today, and frankly there is still a good deal of code included that we found difficult to follow.
It's possible there may be something we missed, but we figured easiest to just go ahead and deploy in Private Beta in order that you can test this end-to-end to ensure everything is working as expected.
packages/browser-destinations/destinations/evolv-ai/src/index.ts
Outdated
Show resolved
Hide resolved
packages/browser-destinations/destinations/evolv-ai/src/source/index.ts
Outdated
Show resolved
Hide resolved
packages/browser-destinations/destinations/evolv-ai/src/source/index.ts
Outdated
Show resolved
Hide resolved
…/index.ts Co-authored-by: Thomas Gilbert <[email protected]>
@rcowin can you pull from main and address the merge conflicts? |
hi @rcowin and @tcgilbert - just FYI there are a number of changes to other Destinations in this PR. Could they be removed please, even if they are just formatting changes? |
e91c2c7
to
b0e3762
Compare
@rcowin still seeing files unrelated to evolv-ai in the PR. Any file that does not live in the evolv-ai directory should be removed. Perhaps it would be easier to create a new branch and pull request if the git commits are too tangled up at this point. |
247b08a
to
72d1126
Compare
A summary of your pull request, including the what change you're making and why.
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.