Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evolv dest actions #2178

Closed
wants to merge 19 commits into from
Closed

Evolv dest actions #2178

wants to merge 19 commits into from

Conversation

rcowin
Copy link

@rcowin rcowin commented Jul 15, 2024

A summary of your pull request, including the what change you're making and why.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • [ x ] Added unit tests for new functionality
  • [ x ] Tested end-to-end using the local server
  • [Segmenters] Tested in the staging environment

@joe-ayoub-segment
Copy link
Contributor

hi @rcowin thanks for raising this PR. I'll schedule for review.

@joe-ayoub-segment
Copy link
Contributor

Hi @rcowin - thanks for raising the PR.

I didn't have time to do a proper review yet. I just scanned through the labels and descriptions and left some comments.
I'll schedule some later this week to review properly.

Best regards,
Joe

@joe-ayoub-segment
Copy link
Contributor

Oh yes @rcowin please note that some CI checks are failing. Could you take a look at this also?

@rcowin
Copy link
Author

rcowin commented Aug 16, 2024

@tcgilbert build should be fixed. sorry - one of the files had incomplete update.

@rcowin
Copy link
Author

rcowin commented Aug 16, 2024

How do other optimization tools (VWO and Optimizely) send experiment confirmation events (or do they) as well as consume segment content?

Copy link
Contributor

@tcgilbert tcgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of changes to make.

@joe-ayoub-segment and I went over this PR again today, and frankly there is still a good deal of code included that we found difficult to follow.

It's possible there may be something we missed, but we figured easiest to just go ahead and deploy in Private Beta in order that you can test this end-to-end to ensure everything is working as expected.

@tcgilbert
Copy link
Contributor

@rcowin can you pull from main and address the merge conflicts?

@joe-ayoub-segment
Copy link
Contributor

hi @rcowin and @tcgilbert - just FYI there are a number of changes to other Destinations in this PR. Could they be removed please, even if they are just formatting changes?

@tcgilbert
Copy link
Contributor

tcgilbert commented Sep 10, 2024

@rcowin still seeing files unrelated to evolv-ai in the PR. Any file that does not live in the evolv-ai directory should be removed.

Perhaps it would be easier to create a new branch and pull request if the git commits are too tangled up at this point.
Screenshot 2024-09-10 at 1 23 46 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants