Skip to content

Commit

Permalink
Upgrade lerna and nx
Browse files Browse the repository at this point in the history
  • Loading branch information
varadarajan-tw committed Oct 16, 2024
1 parent bfd364a commit c92fbca
Show file tree
Hide file tree
Showing 8 changed files with 1,206 additions and 1,675 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/ext.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,6 @@ jobs:
- name: Install
run: yarn install --frozen-lockfile --ignore-optional

- name: Bootstrap
run: yarn bootstrap --no-ci

- name: Test
run: yarn test

Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/publish-canary.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ jobs:
build-and-publish:
env:
HUSKY: 0
NX_DISABLE_DB: true
if: startsWith(github.event.head_commit.message, 'Publish') == true
runs-on: ubuntu-20.04

Expand All @@ -32,7 +33,7 @@ jobs:
cache: yarn

- name: Install Dependencies
run: yarn install --frozen-lockfile --ignore-optional
run: yarn install --frozen-lockfile

- name: Build
run: NODE_ENV=production yarn build
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ jobs:
build-and-publish:
env:
HUSKY: 0
NX_DISABLE_DB: true
if: startsWith(github.event.head_commit.message, 'Publish') == true
runs-on: ubuntu-20.04

Expand Down
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,5 @@ coverage
playwright-report

# NX
.nx
.nx/cache
.nx/workspace-data
1 change: 0 additions & 1 deletion lerna.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
"packages": ["packages/*", "packages/browser-destinations/destinations/*"],
"npmClient": "yarn",
"version": "independent",
"useWorkspaces": true,
"command": {
"bootstrap": {
"npmClientArgs": ["--ignore-engines", "--ignore-optional"]
Expand Down
18 changes: 5 additions & 13 deletions nx.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,25 +13,17 @@
"!{projectRoot}/**/test/**/*"
]
},
"tasksRunnerOptions": {
"default": {
"runner": "nx/tasks-runners/default",
"options": {
"cacheableOperations": ["build", "test"]
}
}
},
"targetDefaults": {
"build": {
"inputs": ["production", "^production"],
"dependsOn": ["^build"]
"dependsOn": ["^build"],
"cache": true
},
"test": {
"inputs": ["default", "^production"],
"dependsOn": ["build"]
"dependsOn": ["build"],
"cache": true
}
},
"affected": {
"defaultBase": "main"
}
"defaultBase": "main"
}
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
},
"scripts": {
"alpha": "lerna version prerelease --allow-branch $(git branch --show-current) --preid $(git branch --show-current) --no-push --no-git-tag-version",
"bootstrap": "lerna bootstrap",
"browser": "yarn workspace @segment/browser-destinations",
"build": "nx run-many -t build && yarn build:browser-bundles",
"build:browser-bundles": "nx build @segment/destinations-manifest && nx build-web @segment/browser-destinations",
Expand Down Expand Up @@ -61,7 +60,7 @@
"karma-jasmine": "^5.1.0",
"karma-webkit-launcher": "^2.0.0",
"karma-webpack": "^5.0.0",
"lerna": "^6.5.0",
"lerna": "^8.1.8",
"lint-staged": "^10.5.3",
"open": "^8.4.0",
"os-browserify": "^0.3.0",
Expand Down
Loading

0 comments on commit c92fbca

Please sign in to comment.