Skip to content

Commit

Permalink
[Required Field Check] Fixes syntax error while printing out required…
Browse files Browse the repository at this point in the history
… field changes (#2504)
  • Loading branch information
varadarajan-tw authored Oct 15, 2024
1 parent fa507d4 commit 2e9f302
Showing 1 changed file with 12 additions and 5 deletions.
17 changes: 12 additions & 5 deletions .github/workflows/required-field-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,12 @@ jobs:
const mainRequiredFields = requiredFieldsOnMain[key][actionKey]
const diff = branchRequiredFields.filter(field => !mainRequiredFields?.includes(field))
if(diff.length > 0) {
const actionOrSettings = actionKey === 'settings' ? '**Setting**' : `**${actionOrSettings}**:${actionKey},`
fieldsAdded.push(`- **Destination**: ${key}, ${actionOrSettings} **Field(s)**:${diff.join(',')}`)
const isSettingsKey = actionKey === 'settings'
if (isSettingsKey) {
fieldsAdded.push(`- **Destination**: ${key}, **Settings**:${diff.join(',')}`)
} else {
fieldsAdded.push(`- **Destination**: ${key}, Action **Field(s)**:${diff.join(',')}`)
}
}
}
} else {
Expand All @@ -89,9 +93,12 @@ jobs:
const getActionKeys = Object.keys(requiredFieldsOnBranch[key])
for(const actionKey of getActionKeys) {
const branchRequiredFields = requiredFieldsOnBranch[key][actionKey]
const actionOrSettings = actionKey === 'settings' ? 'Settings' : 'Action'
fieldsAdded.push(`- **Destination**: ${key}, **${actionOrSettings}**:${actionKey}, **Fields**:${branchRequiredFields.join(',')}`)
}
if(actionKey === 'settings') {
fieldsAdded.push(`- **Destination**: ${key}, **Settings**:${branchRequiredFields.join(',')}`)
} else {
fieldsAdded.push(`- **Destination**: ${key}, **Action**:${actionKey}, **Fields**:${branchRequiredFields.join(',')}`)
}
}
}
})
}
Expand Down

0 comments on commit 2e9f302

Please sign in to comment.