Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace polished dependency with CSS relative color syntax and color-mix #384

Merged
merged 3 commits into from
Dec 15, 2024

Conversation

askoufis
Copy link
Contributor

@askoufis askoufis commented Dec 11, 2024

Since the release of Safari 18, relative color syntax and color-mix have adequate browser support and should be bug-free. This means we can safely replace polished with native CSS.

polished was only used at build-time, so this doesn't affect bundle size at all.

I checked all the colors affected by these changes. In most cases, the colors are identical (when converted to rgb), with a few having slightly different values, e.g. the blue channel increases by 1. I think this is acceptable.

Additionally, usage of rgba was replaced with rgb as rgba is considered legacy and rgb is recommended over it.

@askoufis askoufis requested a review from a team as a code owner December 11, 2024 00:15
Copy link

changeset-bot bot commented Dec 11, 2024

🦋 Changeset detected

Latest commit: fd1898a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
playroom Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@askoufis askoufis merged commit 6095dc4 into master Dec 15, 2024
6 checks passed
@askoufis askoufis deleted the remove-polished-dep branch December 15, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants